DM-11090: Identify regression in HSC astrometric matching success rate between w_2017_17 and w_2017_25 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expansion of the bbox search radius for reference objects to bbox + maxOffsetPix (added in DM-9750) caused a significant regression in the astrometric matching. It seems this is due to an issue with how matchOptimisticB is handling large numbers of reference stars. The default in obs_subaru of maxOffsetPix = 750 resulted in a significant number of CCDs failing in processCcd (identified in DM-11020). Here we set that default to maxOffsetPix = 250 which effectively results in the same number of CCDs in the RC dataset passing single frame processing and equivalent quality based on a comparison of QA plots for the pre- regression and post-fix runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expansion of the bbox search radius for reference objects to
bbox + maxOffsetPix (added in DM-9750) caused a significant regression
in the astrometric matching. It seems this is due to an issue with how
matchOptimisticB is handling large numbers of reference stars. The
default in obs_subaru of maxOffsetPix = 750 resulted in a significant
number of CCDs failing in processCcd (identified in DM-11020). Here we
set that default to maxOffsetPix = 250 which effectively results in the
same number of CCDs in the RC dataset passing single frame processing
and equivalent quality based on a comparison of QA plots for the pre-
regression and post-fix runs.