Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mappers for QA parquet tables #93

Merged
merged 4 commits into from Oct 2, 2017
Merged

Add mappers for QA parquet tables #93

merged 4 commits into from Oct 2, 2017

Conversation

timothydmorton
Copy link
Contributor

DM-12030 adds parquet table persistence to the pipe_analysis scripts. Here, we add the necessary Butler mappers so that they can get the right filenames.

@timothydmorton
Add mapper for parquet tables for QA
329f1bd 
DM-12030 adds parquet table persistance to the pipe_analysis scripts.
Here, we add the necessary Butler mappers so that they can get the right
filenames.
@timothydmorton
fix merge conflict
496f50c
PaulPrice
PaulPrice reviewed Sep 27, 2017
View reviewed changes
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fairly camera-agnostic. Perhaps they should go in obs_base instead?

@timothydmorton
Copy link
Contributor Author

filter, tract and visit are all camera-agnostic? Did I hear someone say earlier that visit is not, or did I misunderstand?

@PaulPrice
Copy link
Contributor

Maybe visit is not. But in any case, everything but for the template should go in obs_base if you intend that any of this be used for other cameras.

@TallJimbo
Copy link
Member

TallJimbo commented Sep 27, 2017 •
edited

visit and ccd are not camera agnostic.

tract and patch definitely are. filter is camera-agnostic, but its values are not.

@TallJimbo TallJimbo closed this Sep 27, 2017
@TallJimbo TallJimbo reopened this Sep 27, 2017
@timothydmorton
Copy link
Contributor Author

So, I should put qaTableCoadd and qaTableColor into obs_base, leaving qaTableVisit in obs_subaru?

@PaulPrice
Copy link
Contributor

No, everything except the template that has visit in it goes into obs_base. Then only the template that has visit in it stays in obs_subaru.

@timothydmorton
Copy link
Contributor Author

OK, so I should include a definition of the qaTableVisit in obs_base, but just leave template blank? Am I understanding that correctly?

@PaulPrice
Copy link
Contributor

Final product looks good. Please squash the three commits before merging.

@timothydmorton timothydmorton merged commit cb35f37 into master Oct 2, 2017
@ktlim ktlim deleted the tickets/DM-12030 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPrice PaulPrice PaulPrice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timothydmorton @PaulPrice @TallJimbo