Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-12103: Investigate centering for vignetted pupils #96

Merged
merged 1 commit into from Nov 7, 2017
Merged

DM-12103: Investigate centering for vignetted pupils #96

merged 1 commit into from Nov 7, 2017

Conversation

jmeyers314
Copy link
Contributor

No description provided.

mfisherlevine
mfisherlevine reviewed Nov 6, 2017
View reviewed changes
Copy link
Contributor

@mfisherlevine mfisherlevine left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure you've thought about this, but just wanted to confirm. With you setting doCenter=True in the init, you're keeping this new functionality as optional, but also making it the default, and thus changing current behaviour. Is this correct? Probably fine as long as you've thought about it.

@jmeyers314
Copy link
Contributor Author

I'm sure you've thought about this, but just wanted to confirm. With you setting doCenter=True in the init, you're keeping this new functionality as optional, but also making it the default, and thus changing current behaviour. Is this correct? Probably fine as long as you've thought about it.

Yep. I want it to be the new default. I seriously doubt anybody but me is currently using this code, so shouldn't be a problem.

@jmeyers314 jmeyers314 merged commit 5d7c7ee into master Nov 7, 2017
@ktlim ktlim deleted the tickets/DM-12103 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfisherlevine mfisherlevine mfisherlevine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmeyers314 @mfisherlevine