DM-12445: Set appropriate default configs for CompareWarp Coadds #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
changed the title
PaulPrice
approved these changes
Nov 16, 2017
config/makeCoaddTempExp.py
Outdated
| config.makePsfMatched=True | ||
| config.warpAndPsfMatch.psfMatch.kernel['AL'].kernelSize=29 | ||
| config.warpAndPsfMatch.psfMatch.kernel['AL'].alardSigGauss=[1.0, 2.0, 4.5] | ||
| config.modelPsf.defaultFwhm=7.7 |
There was a problem hiding this comment.
Spaces either side of the = please.
config/coaddDriver.py
Outdated
| config.assembleCoadd.retarget(CompareWarpAssembleCoaddTask) | ||
| config.assembleCoadd.assembleStaticSkyModel.subregionSize = (10000, 200) | ||
| config.assembleCoadd.assembleStaticSkyModel.badMaskPlanes = ("BAD", "EDGE", "SAT", "INTRP", "NO_DATA",) | ||
| config.assembleCoadd.assembleStaticSkyModel.doApplyUberCal = True |
There was a problem hiding this comment.
To eliminate code duplication, this should load the configuration from the configuration file for compareWarpAssembleCoadd (like below). And I think the additional loading below may potentially clobber what you've got here.
There was a problem hiding this comment.
Agreed. Note that by that reasoning it currently should be reading in safeClipAssembleCoadd.py
There was a problem hiding this comment.
I think https://jira.lsstcorp.org/browse/DM-10634 might be relevant here.
yalsayyad
force-pushed
the
tickets/DM-12445
branch
2 times, most recently
from
a0d7b8c
to
3f3b646
Compare
including making psfMatched Warps by default.
yalsayyad
force-pushed
the
tickets/DM-12445
branch
from
3f3b646
to
4c49300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.