DM-12765: HSC-specific plugin for recording filter ratios. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-12765
branch
from
0429519
to
85d924d
Compare
TallJimbo
force-pushed
the
tickets/DM-12765
branch
from
85d924d
to
c78523a
Compare
rearmstr
reviewed
Nov 28, 2017
| raise lsst.meas.base.FatalAlgorithmError( | ||
| "Unexpected filter combination found in coadd: %s" % counts.keys() | ||
| ) | ||
| measRecord.set(self.key, counts.get("i2", 0.0)/len(overlapping)) |
There was a problem hiding this comment.
Do the filter ratios need to take into account the CCD weights?
There was a problem hiding this comment.
They do not. I had always planned to include that when actually adding the transmission curves, and for some reason I thought it was nonsensical to do it now. That's clearly not true, and I think I'll have the algorithm produce both a weighted and an unweighted fraction; the weights are already all there.
PaulPrice
pushed a commit
to HyperSuprime-Cam/obs_subaru
that referenced
this pull request
Dec 9, 2017
DM-12765: HSC-specific plugin for recording filter ratios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.