DM-39857: Major cleanup #102
Conversation
Can not use importlib import mode because of the tests importing code from subdirectories.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 85.24% 85.33% +0.08%
==========================================
Files 46 46
Lines 3627 3621 -6
==========================================
- Hits 3092 3090 -2
+ Misses 535 531 -4
☔ View full report in Codecov by Sentry. |
|
@TallJimbo most of the commits do not need reviewing. I've tried to make it clear which ones are fixes for sphinx, and which are automated. I did do some commits to fix warnings that involved actual code changes. |
There was a problem hiding this comment.
One commit here has a lot of namespace-qualification in docs that I would not have thought was necessary.
I didn't look at the "modernize type annotations" or "modernize string formatting" commits at all as I guessed those were fully automated.
Otherwise looks good!
python/lsst/pex/config/configurableActions/_configurableAction.py
Outdated
Show resolved
Hide resolved
This means that the file will be cleaned up automatically and the coverage code will no longer complain about coverage in python files it wasn't meant to be finding.
Pytest looks for tests in classes named TestX. Importing TestConfig therefore triggers a warning. Now reference it from the original package.
Modified find_module to be compatible with find_spec. Fixes this warning: tests/test_Config.py::ConfigTest::testBadImports tests/test_Config.py::ConfigTest::testImports <frozen importlib._bootstrap>:914: ImportWarning: RecordingImporter.find_spec() not found; falling back to find_module()
--flake8test option.Checklist
doc/changes