Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40198 Allow extra local variables when loading configs #104

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

natelust
Copy link
Contributor

Allow a dictionary of variables to be used in local scope when configs are loaded from a stream or string.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (733a212) 85.33% compared to head (07727ac) 85.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   85.33%   85.37%   +0.04%     
==========================================
  Files          46       46              
  Lines        3621     3631      +10     
==========================================
+ Hits         3090     3100      +10     
  Misses        531      531              
Files Changed Coverage Δ
python/lsst/pex/config/config.py 90.69% <100.00%> (+0.08%) ⬆️
tests/test_Config.py 95.89% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natelust natelust force-pushed the tickets/DM-40198 branch 2 times, most recently from ee5cf75 to 25fd9d6 Compare July 27, 2023 21:11
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've heard that we can and should just remove the --- in .github/workflows/rebase_checker.yaml that yields the warning at the bottom of the PR when we see it.

python/lsst/pex/config/config.py Outdated Show resolved Hide resolved
Allow a dictionary of variables to be used in local scope when
configs are loaded from a stream or string.
@natelust natelust merged commit 22560d9 into main Jul 28, 2023
11 checks passed
@natelust natelust deleted the tickets/DM-40198 branch July 28, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants