Fix ConfigDict's handling of unicode keys
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `ConfigDict.__setitem__` call `_autocast` before checking the key type, just like `Dict` does. Add a unicode key in the unit test for each so that this is tested (and I confirmed the fix by commenting out the call to `_autocast` in both dict classes, and two tests failed. This solves a problem that pybind11 returns unicode strings from C++ methods that return std::string; the problem was showing up in afw's `testCameraGeom.py`.
timj
commented
Dec 12, 2016
| @@ -48,6 +48,7 @@ def __setitem__(self, k, x, at=None, label="setitem", setHistory=True): | |||
| raise FieldValidationError(self._field, self._config, msg) | |||
|
|
|||
| # validate keytype | |||
| k = _autocast(k, self._field.keytype) | |||
There was a problem hiding this comment.
@r-owen it's probably the case that we should be using _autocast more consistently in pex_config. This works because a future str is an instance of unicode, although at present, you end up with the unicode-ness being stripped so this is going to fail (and pex_config will fail in general) if we pass in unicode strings that can't be converted to native Python 2 str. There are advantages to dropping Python 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ConfigDict.__setitem__call_autocastbefore checking the key type, just likeDictdoes. Add a unicode key in the unit test for each so that this is tested (and I confirmed the fix by commenting out the call to_autocastin both dict classes, and two tests failed.This solves a problem that pybind11 returns unicode strings from C++ methods that return std::string; the problem was showing up in afw's
testCameraGeom.py.