DM-11514: Fix pytest execution from scons #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Aug 8, 2017
timj
commented
- Ignore the pybind11 python file when testing.
- Rename tests following new standard
- Remove executable bit.
SimonKrughoff
approved these changes
Aug 8, 2017
| @@ -1,4 +1,5 @@ | |||
| # -*- python -*- | |||
| from lsst.sconsUtils import scripts | |||
| scripts.BasicSConscript.pybind11(['testLib']) | |||
| scripts.BasicSConscript.tests(noBuildList=['testLib.cc']) | |||
There was a problem hiding this comment.
How did this work before? It seems like it would have always failed if the library is not built.
There was a problem hiding this comment.
Pybind11 now builds it, so it needs to be disabled from the list of things that the test system has to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.