Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly document non-optional Fields. #29

Merged
merged 1 commit into from Nov 14, 2018
Merged

Properly document non-optional Fields. #29

merged 1 commit into from Nov 14, 2018

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Nov 14, 2018

No description provided.

kfindeisen
kfindeisen approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 for making the code more readable.

@ktlim ktlim merged commit 9645df7 into master Nov 14, 2018
@ktlim ktlim deleted the tickets/DM-16505 branch November 14, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ktlim @kfindeisen