Ensure that config uses native str internally #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +64,8 @@ def _autocast(x, dtype): | |||
| return float(x) | |||
| if dtype == int and isinstance(x, long): | |||
| return int(x) | |||
| if isinstance(x, str): | |||
There was a problem hiding this comment.
Why can't we just use from builtins import str everywhere?
There was a problem hiding this comment.
As I say in lsst/afw#83 the problem is that I can't promise that people outside are giving me str. The reason this exists is because tests started failing in afw and I can imagine code further up the stack also not doing it consistently. That and the fact that string literals are not future str leads me to believe this is the only option. Casting to a proper str is probably the best thing anyhow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cast future "newstr" objects to native "str" for consistency.