Merge pull request #21 from lsst/tickets/DM-15151

DM-15151: Set symbol visibility to hidden in pybind11 wrappers
lsst · Sep 12, 2018 · aa49eb3 · aa49eb3
2 parents f4e7cdd + 664d8b1
commit aa49eb3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -0,0 +1,8 @@
+sudo: false
+language: python
+matrix:
+  include:
+    - python: '3.6'
+      install:
+      - pip install flake8
+      script: flake8
diff --git a/include/lsst/pex/exceptions/Exception.h b/include/lsst/pex/exceptions/Exception.h
@@ -29,6 +29,7 @@
 #include <string>
 #include <vector>
 
+#include "lsst/base.h"
 #include "boost/current_function.hpp"
 
 namespace lsst {
@@ -66,7 +67,7 @@ namespace exceptions {
  * @param[in] c C++ class of the exception (fully specified).
  */
 #define LSST_EXCEPTION_TYPE(t, b, c)                                                          \
-    class t : public b {                                                                      \
+    class LSST_EXPORT t : public b {                                                                      \
     public:                                                                                   \
         t(LSST_EARGS_TYPED) : b(LSST_EARGS_UNTYPED){};                                        \
         t(std::string const& message) : b(message){};                                         \
@@ -103,7 +104,7 @@ typedef std::vector<Tracepoint> Traceback;
  *
  * In Python, this exception inherits from `__builtin__.Exception`.
  */
-class Exception : public std::exception {
+class LSST_EXPORT Exception : public std::exception {
 public:
     /**
      * Standard constructor, intended for C++ use via the LSST_EXCEPT() macro.