DM-11658: Enable flake8 testing #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unused install_aliases() call as none of the packages were being imported that needed this alias.
pschella
reviewed
Aug 26, 2017
setup.cfg
Outdated
| @@ -0,0 +1,8 @@ | |||
| [flake8] | |||
| max-line-length = 110 | |||
| ignore = E133, E226, E228, N802, N803, W503 | |||
There was a problem hiding this comment.
What are these and why are they ignored?
There was a problem hiding this comment.
They are the standard ignore codes documented in the developer guide.
https://developer.lsst.io/coding/python_style_guide.html#exceptions-to-pep-8
(although two of the ones in the dev guide aren't relevant here: I probably should add them in for consistency).
pschella
reviewed
Aug 26, 2017
setup.cfg
Outdated
|
|
||
| [tool:pytest] | ||
| addopts = --flake8 | ||
| flake8-ignore = E133 E226 E228 N802 N803 W503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.