DM-7021: Port to Python 3 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ def __getattr__(self, name): | |||
| return getattr(self.WrappedClass, name) | |||
|
|
|||
| @register | |||
| class Exception(StandardError): | |||
| class Exception(Exception): | |||
There was a problem hiding this comment.
Umm... This looks like it's inheriting from itself. Spontaneous generation?
There was a problem hiding this comment.
See the next commit bc39756 which fixes this. Probably should squash the two.
There was a problem hiding this comment.
How come github thinks this is commenting on an outdated diff?
* Use builtins package not __builtins__. * Portable metaclass. * StandardError has gone * Exception inherits from builtins.Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.