Skip to content

Commit

Permalink
Remove an assert against component outputs.
Browse files Browse the repository at this point in the history
The assert inadvertently catches component *inputs* because of an
unidentified bug elsewhere. This breaks all pipelines that use the
default config for ip.diffim.GetTemplateTask.
  • Loading branch information
kfindeisen committed Oct 10, 2022
1 parent dba8530 commit 759a9bc
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion python/lsst/pipe/base/graphBuilder.py
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,10 @@ def resolveDatasetRefs(
)
isInit = datasetType in self.initIntermediates or datasetType in self.initOutputs
subset = commonDataIds.subset(datasetType.dimensions, unique=True)
assert not datasetType.isComponent(), "Output datasets cannot be components."
# TODO: this assert incorrectly bans component inputs;
# investigate on DM-33027.
# assert not datasetType.isComponent(), \
# "Output datasets cannot be components."

# look at RUN collection first
if run is not None:
Expand Down

0 comments on commit 759a9bc

Please sign in to comment.