Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-21390: Add a show option to examine a qgraph #103

Merged
merged 1 commit into from Oct 11, 2019
Merged

Conversation

hsinfang
Copy link
Contributor

@hsinfang hsinfang commented Oct 9, 2019

No description provided.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK, couple of minor comments.

@@ -173,6 +173,21 @@ def quanta(self):
for quantum in taskNodes.quanta:
yield taskDef, quantum

def quanta_as_qgraph(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other methods I think it better to use camelCase for method name (quantaAsQgraph).

------
graph : `QuantumGraph`
"""
for (taskDef, quantum) in self.quanta():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parentheses are not needed here.

@hsinfang hsinfang merged commit e99a47f into master Oct 11, 2019
@timj timj deleted the tickets/DM-21390 branch April 13, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants