DM-4236 #11
Merged
DM-4236 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.error("no output directory specified.\n" | ||
| "An output directory must be specified with the --output or --rerun\n" | ||
| "command-line arguments or the PIPE_OUTPUT_ROOT environment variable.\n") | ||
|
|
There was a problem hiding this comment.
I suggest removing the bit about PIPE_OUTPUT_ROOT (but see associated request near line 515)
PaulPrice
force-pushed
the
tickets/DM-4236
branch
from
4b9fd8a
to
7e92005
Compare
# The first commit's message is: ArgumentParser: require an output to be specified This prevents unintentionally writing in the top-level data repo by leaving off "--output" or "--rerun" or $PIPE_OUTPUT_ROOT. If none of these is set, we error out. This behavior can be disabled by setting ArgumentParser.requireOutput = False. In the process, cleaned up the rerun handling, so that the actual rerun name is stored in namespace.rerun instead of a directory. Added a test demonstrating various ways of specifying the output directory. # This is the 2nd commit message: squash! ArgumentParser: require an output to be specified Add InputOnlyArgumentParser
This prevents unintentionally writing in the top-level data repo by leaving off "--output" or "--rerun" or $PIPE_OUTPUT_ROOT. If none of these is set, we error out. This behavior can be disabled by setting ArgumentParser.requireOutput = False or by using the InputOnlyArgumentParser. In the process, cleaned up the rerun handling, so that the actual rerun name is stored in namespace.rerun instead of a directory. Added a test demonstrating various ways of specifying the output directory.
$PIPE_OUTPUT_ROOT should be a parent directory. Stop using it as a default output directory if --output or --rerun not specified.
PaulPrice
force-pushed
the
tickets/DM-4236
branch
from
7e92005
to
d2c25a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents unintentionally writing in the top-level data repo
by leaving off "--output" or "--rerun" or $PIPE_OUTPUT_ROOT. If
none of these is set, we error out. This behavior can be disabled
by setting ArgumentParser.requireOutput = False.
In the process, cleaned up the rerun handling, so that the actual
rerun name is stored in namespace.rerun instead of a directory.
Added a test demonstrating various ways of specifying the output
directory.