DM-23477: Allow ScalarError to be constructed from a single parameter #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this class is used in multiprocessing environment ScalarError must be pickled. When being pickled only the single string passed to TypeError is serialized. This leads to an initialization error when the object is recreated and breaks error reporting. Change things so that a single parameter acts like any other standard exception.
natelust
approved these changes
Feb 12, 2020
|
I prefer to not implement reduce if we can avoid it. I guess we never had a failure at this specific point with multiprocessing turned on before, I cant see any minor change to python version could cause this to start failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this class is used in multiprocessing environment ScalarError
must be pickled. When being pickled only the single string passed
to TypeError is serialized. This leads to an initialization error
when the object is recreated and breaks error reporting.
Change things so that a single parameter acts like any other
standard exception.