Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23722: Complain if the dataset type is different to registry #122

Merged
merged 2 commits into from Mar 16, 2020
Merged

DM-23722: Complain if the dataset type is different to registry #122

merged 2 commits into from Mar 16, 2020

Conversation

timj
Copy link
Member

@timj timj commented Mar 14, 2020

No description provided.

@timj timj requested a review from TallJimbo March 14, 2020 16:55
@timj
Allow the dataset type to not be defined yet
d1453e0 
We may be wanting to register it later.
andy-slac
andy-slac approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 4335de3 into master Mar 16, 2020
@timj timj deleted the tickets/DM-23722 branch March 16, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-slac andy-slac andy-slac approved these changes

@TallJimbo TallJimbo Awaiting requested review from TallJimbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @andy-slac