DM-23173: change to binary operators at beginning of new line #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix the resulting flake8 warnings, all of which were for strings in cmdLineTask.py that I changed to f strings.
and sys.stderr.write instead of print(..., file=sys.stderr) (the old code was a mix).
timj
reviewed
Apr 9, 2020
| @@ -1039,7 +1038,7 @@ def write(self, showStr): | |||
| matHistory = re.search(r"^(?:config.)?(.+)?", showArgs) | |||
| globPattern = matHistory.group(1) | |||
| if not globPattern: | |||
| print("Please provide a value with --show history (e.g. history=*.doXXX)", file=sys.stderr) | |||
| sys.stderr.write("Please provide a value with --show history (e.g. history=*.doXXX)\n") | |||
There was a problem hiding this comment.
I don't like this at all. What's the justification given that file=sys.stderr is a good option already.
There was a problem hiding this comment.
The justification is that the existing code is a mix of the two styles (even within the same module). I feel write is a bit cleaner, though it does risk forgetting the final \n. In any case I think we should pick one and stick to it.
There was a problem hiding this comment.
Since you prefer print and I don't have strong feelings either way I updated the code to use print everywhere. It was all in this one module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: