DM-25016: Add save/restore methods to QuantumGraph #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
May 24, 2020
python/lsst/pipe/base/graph.py
Outdated
| @@ -155,6 +156,54 @@ def __init__(self, iterable=None): | |||
| This is disjoint from both `initInputs` and `initIntermediates`. | |||
| """ | |||
|
|
|||
| @classmethod | |||
| def restore(cls, file, universe): | |||
There was a problem hiding this comment.
We don't have any formal conventions for this, as far as I know, but I think load is a more common name for a method like this.
There was a problem hiding this comment.
👍 OK, will rename it to load
Restoring QuantumGraph from pickle requires that DimensionUniverse instance exists, restore method ensures that this is true by accepting a dummy argument.
andy-slac
force-pushed
the
tickets/DM-25016
branch
from
e6708e4
to
a204e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring QuantumGraph from pickle requires that DimensionUniverse
instance exists, restore method ensures that this is true by accepting a
dummy argument.