DM-26144 Inherit configs when inheriting a Pipeline #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a declared label exists in an inherited Pipeline, and the class attribute matches, include the configs from the inherited pipeline. If the class attribute does not match, replace the definition associated with that label.
When building an expanded pipeline from a Pipeline, expand any environment variables in a config file path
natelust
force-pushed
the
tickets/DM-26144
branch
from
211111f
to
2557889
Compare
czwa
approved these changes
Jul 29, 2020
The PipelineIR unittest relied on a side effect of a previous line of execution for a test to pass. Change the test to use a different object so that it is robust against future changes to the test that may cause a failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Pipeline is inherited that matches a label with the same task current Pipeline, inherit the configs for that label. Otherwise only use the definition from the current Pipeline.
Second commit:
Because I was in pipe_base anyway, a second commit adds the ability to specify a config file path that includes shell variables. These variables will be expanded when a Pipeline is converted to an expanded Pipeline.