DM-26774: Instrument-finding code incorrectly requires a data query #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8pease
force-pushed
the
tickets/DM-26774
branch
from
97c242c
to
a6bf8b3
Compare
timj
approved these changes
Sep 21, 2020
andy-slac
approved these changes
Sep 23, 2020
| @@ -153,7 +180,21 @@ def registerDatasetTypes(registry, pipeline): | |||
| registry.registerDatasetType(datasetType) | |||
|
|
|||
|
|
|||
| def makeSimpleQGraph(nQuanta=5, pipeline=None, butler=None, root=None, skipExisting=False, inMemory=True): | |||
| def makeSimplePipeline(nQuanta, instrument=None): | |||
There was a problem hiding this comment.
Docstring would be nice.
|
|
||
|
|
||
| def makeSimpleQGraph(nQuanta=5, pipeline=None, butler=None, root=None, skipExisting=False, inMemory=True, | ||
| userQuery=""): |
There was a problem hiding this comment.
Can you add docstring for userQuery?
tests/test_graphBuilder.py
Outdated
| def testDefault(self): | ||
| """Simple test to verify makeSimpleQGraph can be used to make a Quantum | ||
| Graph.""" | ||
| with tempfile.TemporaryDirectory() as root: |
There was a problem hiding this comment.
Tim pointed out to me that tempfile.TemporaryDirectory may not behaving well if there are errors during deleting the directory, it does not specify ignore_errors=True when it calls shutil.rmtree. I had to implement trivial context manager to workaround that: https://github.com/lsst/ctrl_mpexec/blob/master/tests/test_cmdLineFwk.py#L78-L87. I think you need something like that too (better of course is to have it somewhere in the common code base but I don't know where that could be). Same for the method below.
n8pease
force-pushed
the
tickets/DM-26774
branch
2 times, most recently
from
5a70acb
to
b1b024e
Compare
on branch tickets/DM-26774-transfer
on branch tickets/DM-26774-transfer
on branch tickets/DM-26774-transfer
n8pease
force-pushed
the
tickets/DM-26774
branch
from
b1b024e
to
d223dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.