DM-27034: Don't import daf_butler symbols from internal module. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Oct 2, 2020
TallJimbo
force-pushed
the
tickets/DM-27034
branch
from
c7e6b71
to
0bf870c
Compare
This is a case study in why underscore-prefixed submodules are a good idea.
Entries with no keys defined are DimensionElements, but not Dimensions, and are not permitted in (e.g.) data IDs. This code was always wrong, but daf_butler only recently starting catching the error.
TallJimbo
force-pushed
the
tickets/DM-27034
branch
from
0bf870c
to
f8115d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a case study in why underscore-prefixed submodules are a good idea.