Tickets/dm 6074 #16
Merged
Tickets/dm 6074 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine two tests that had identical names (one shadowed the other). "not a in b" -> "a not in b" One statement per line. Break a few lines that were too long. Remove trailing whitespace.
| @@ -172,13 +172,27 @@ is to use a camera-specific variant of a subtask. Examples include: | |||
| - lsst.obs.sdss.selectSdssImages.SelectSdssImagesTask: an version of the task that selects images | |||
| for co-addition of SDSS stripe 82 images | |||
|
|
|||
| Here is an example of retargeting a subtask in a config override file; this retargets | |||
| lsst.pipe.tasks.exampleCmdLineTask.ExampleCmdLineTask `stats` with a simpler version: | |||
| How you retarget a subtask depends if the subtask is specified as an | |||
There was a problem hiding this comment.
I will change "if" to "on whether" as you suggest.
I believe "an" is correct before "LSST" since the L is pronounced "ell".
Actually, Task.makeTask already supported subtasks held in pexConfig.RegistryField, but it was not documented or tested. Document this and add a test. Also rename a variable to make the code less confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.