DM-27985: Replace instrument check in QG gen with instrument-defaulting. #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a Pipeline that contains an instrument entry now automatically includes that instrument as a constraint in the QG gen query, and daf_butler will check that it's consistent with the instrument provided in the user expression (which after this change is no longer required). This is on the branch for this ticket only because the daf_butler changes for this ticket reshuffled some modules, which broke the code here that was previously using those (internal to daf_butler) interfaces. Happily, this is better behavior, better encapsulation, and less code (well, not overall, but here). On the testing side, we can remove a bunch of tests here (the functionality we delegate to in daf_butler is already tested there), but we also need to make the testing utility code a bit less cavalier, and in particular make the pipeline's instrument agree with the registry's instrument.
TallJimbo
force-pushed
the
tickets/DM-27985
branch
from
4c1eecd
to
059c297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.