DM-27941 Update import system #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Fine other than the missing newline and the request for one more unit test.
More documentation on pipeline yaml syntax would be helpful, even if just a louder note that each section corresponds to a pipelineIR.py "sectionIR" which describes the allowable keys.
| """) | ||
| pipeline = PipelineIR.from_string(pipeline_str) | ||
| self.assertEqual(pipeline.instrument, "new.instrument") | ||
|
|
| if self.instrument is None: | ||
| self.instrument = tmp_IR.instrument | ||
| elif self.instrument != tmp_IR.instrument and tmp_IR.instrument is not None: | ||
| raise ValueError("Only one instrument can be declared in a pipeline or it's imports") |
There was a problem hiding this comment.
Can a unit test be added that exercises this "only one instrument" case?
Change the name of the directive to import. Instruments are now imported, and only one instrument may be defined among the importing Pipeline, and all the imports.
natelust
force-pushed
the
tickets/DM-27941
branch
from
54393d2
to
fb04b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the name of the directive to import. Instruments are now
imported, and only one instrument may be defined among the
importing Pipeline, and all the imports.