DM-29255 Modify applying config overrides for flexibility #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
force-pushed
the
tickets/DM-29255
branch
2 times, most recently
from
90971f1
to
4a3d1bd
Compare
andy-slac
approved these changes
Mar 18, 2021
| @@ -125,35 +227,77 @@ def applyTo(self, config): | |||
| ------ | |||
| `Exception` is raised if operations on configuration object fail. | |||
| """ | |||
| # Look up a stack of variables people may be useing when setting | |||
| # The field might be a string corresponding to a attribute | ||
| # hierarchy, attempt to split off the last field which | ||
| # will then be set. | ||
| parent, *child = field.rsplit(".", maxsplit=1) |
There was a problem hiding this comment.
rpartition may be slightly more readable, but that is a personal preference
natelust
force-pushed
the
tickets/DM-29255
branch
5 times, most recently
from
31b495a
to
3843557
Compare
These changes allow greater flexibility when doing config overrieds in areas such as not needing string escaping when working with the command line, and using values from python statements in other parts of pipeline config blocks.
natelust
force-pushed
the
tickets/DM-29255
branch
from
3843557
to
9496650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow greater flexibility when doing config overrieds
in areas such as not needing string escaping when working with the
command line, and using values from python statements in other
parts of pipeline config blocks.