tickets/DM-29345 Add method to get QuantumNodes by TaskDef #175
Conversation
Add a method to the QuantumGraph object that returns all the QuantumNodes associated with a TaskDef.
natelust
force-pushed
the
tickets/DM-29345
branch
from
b132b7d
to
9d7063c
Compare
| @@ -103,6 +103,7 @@ def _buildGraphs(self, | |||
|
|
|||
| nodeNumberGenerator = count() | |||
| self._nodeIdMap: Dict[NodeId, QuantumNode] = {} | |||
| self._taskToQuantumNode: DefaultDict[TaskDef, Set[QuantumNode]] = defaultdict(set) | |||
There was a problem hiding this comment.
I wonder if this is redundant with self._quanta, given that you can get the quantum of a QuantumNode.
There was a problem hiding this comment.
So I thought about that for my first pass at implementing this. However, that would involve either having a mapping of quantum to NodeId (which is easy enough) or QuantumNode. This would involve a pass of looking up all the quanta, loop over them, and then mapping those to QuantumNodes, and then returning this (with a second hop for NodeId for course) I figured that in large graphs it would be worth the memory trade off vs executing a loop and extra mapping lookups in terms of run time.
There are a few different ways to store all this data internally, but I tried to opt for fast lookups vs efficient packing, as the structures themselves are not duplicated, just extra pointers to the structs.
There was a problem hiding this comment.
of course, this could be done the other way, of looking up all the QuantumNodes, extracting the Quantum from then and returning that, but I already had to have the data structure contained in memory of TaskDef to Set[Quantum] to construct the graph, so it seems wasteful to not just use that (again unless we want to free up a dict of pointers)
There was a problem hiding this comment.
Yes, clearly there's several ways of doing it. I wasn't actually thinking about memory usage, but about complexity -- redundant data structures are harder to keep in a self-consistent state, especially in the presence of exceptions.
Add a method to the QuantumGraph object that returns all the
QuantumNodes associated with a TaskDef.