DM-28646 Introduce factory for creating lightweight butlers #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Apr 18, 2021
natelust
force-pushed
the
tickets/DM-28646
branch
from
d8bb948
to
8d01c89
Compare
andy-slac
reviewed
Apr 21, 2021
andy-slac
reviewed
Apr 21, 2021
| exporter.saveDatasets(exports) | ||
|
|
||
| # Look for any defined collection, if not get the defaults | ||
| if (collections := collections) is None: |
There was a problem hiding this comment.
collections := collections? Could just check for None?
There was a problem hiding this comment.
Good catch, that was some version archeology
andy-slac
reviewed
Apr 21, 2021
andy-slac
reviewed
Apr 21, 2021
| butlerModifier: Optional[Callable[[Butler], Butler]] = None, | ||
| collections: Optional[Iterable[str]] = None | ||
| ) -> None: | ||
| r"""buildLightweightButler is an object that is responsible for exporting |
andy-slac
approved these changes
Apr 21, 2021
Introduce a factory class that is initialized with a butler that can be used to convert QuantumGraphs into lightweight sqlite backed butlers containing only the info from the graph.
natelust
force-pushed
the
tickets/DM-28646
branch
from
8d01c89
to
a99c383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a factory class that is initialized with a butler that
can be used to convert QuantumGraphs into lightweight sqlite
backed butlers containing only the info from the graph.