DM-28668: PipelineTask unit test framework bypasses dimensions checks #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2021
taranu
reviewed
Jun 1, 2021
The iterConnections function is easy to overlook, but potentially useful when you don't need the field names for a connection.
kfindeisen
force-pushed
the
tickets/DM-28668
branch
from
efbfca5
to
8f0ed14
Compare
taranu
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to catch connections dimension errors by checking that supplied data IDs in testing match the connections (on the assumption that a mismatch might mean the connections aren't what the test author expected) and by providing a separate function for detecting common errors.