DM-30335: Minor fixes to execution butler #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tler Without this the predicted outputs that rely on new dimensions (such as visit) can't be inserted.
It must be a directory so declare that it is one to avoid confusion. Without this a trailing / is required which will break if the execution butler directory does not yet exist.
TallJimbo
approved these changes
May 27, 2021
| # Need to ensure that the dimension records for outputs are | ||
| # transferred. | ||
| for _, dataIds in inserts.items(): | ||
| exporter.saveDataIds(dataIds) |
There was a problem hiding this comment.
I think this should be fine, but we should be on the lookout for it running into the problem @SimonKrughoff reported here where we export visit records but not visit definition records. I'm not sure exactly what he did differently.
natelust
reviewed
May 27, 2021
| # Requires that we use the dimension configuration from the original | ||
| # butler and not use the defaults. | ||
| config = Butler.makeRepo(root=outputLocation, config=config, | ||
| dimensionConfig=butler.registry.dimensions.dimensionConfig, |
There was a problem hiding this comment.
I wonder if this is the difference between how I was doing things before with initializing the registry explicity vs switching to butler.makeRepo to make the registry in terms of dimensions being transfered.
There was a problem hiding this comment.
We haven't changed dimensions config in a long time so I don't think this would have mattered. It was going to be a potential problem in the future though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.