Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM- 30702 Store Metadata in QuantumGraph #189

Merged
merged 3 commits into from Jun 16, 2021
Merged

DM- 30702 Store Metadata in QuantumGraph #189

merged 3 commits into from Jun 16, 2021

Conversation

natelust
Copy link
Contributor

Checklist

@timj timj changed the title Tickets/DM- 30702 Store Metadata in QuantumGraph DM- 30702 Store Metadata in QuantumGraph Jun 15, 2021
timj
timj reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a little test that creates a quantum graph with a metadata header and shows that you can read the metadata back in?

andy-slac
andy-slac approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few minor comments/questions.

python/lsst/pipe/base/graph/_loadHelpers.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/graph.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/graph.py Show resolved Hide resolved
python/lsst/pipe/base/graph/_loadHelpers.py Outdated Show resolved Hide resolved
@natelust
Copy link
Contributor Author

@timj That is a good catch, I had intended to, and then completely forgot by the time I finished fixing a failure from an existing test.

@natelust
Introduce a new save version with metadata
3d13698 
Change the save format to something more flexible so that metadata
can be easily stored and retrieved.
@natelust
Propagate metadata through graphBuilder
999e42a
@natelust
Added towncrier notes for QuantumGraph
9f5fba9
@natelust natelust merged commit 171cb58 into master Jun 16, 2021
@natelust natelust deleted the tickets/DM-30702 branch June 16, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj left review comments

@andy-slac andy-slac andy-slac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@natelust @timj @andy-slac