DM-6999: Logging framework migration #19
Conversation
hsinfang
force-pushed
the
tickets/DM-6999
branch
5 times, most recently
from
15fba26
to
c649ca9
Compare
| if log is None: | ||
| log = pexLog.getDefaultLog() | ||
| self.log = pexLog.Log(log, self._fullName) | ||
| if log is not None and isinstance(log, Log): |
There was a problem hiding this comment.
Why is the isinstance test? This was not present before and I'm very uncomfortable having it now. Is this a way of trying to avoid pex_logging? If so, is the problem serious enough to need avoiding? If so, please warn or raise if the wrong type of log is passed in. I am uncomfortable with code that silently ignores issues, as it leads to mysterious and silent failures.
There was a problem hiding this comment.
isinstance is not needed here and we can just remove the check. What you said makes more sense; even if the check stays it should warn or raise if the wrong type of log is passed in.
hsinfang
force-pushed
the
tickets/DM-6999
branch
2 times, most recently
from
08dac8a
to
12ab37a
Compare
| @@ -127,7 +127,7 @@ def __init__(self, config=None, name=None, parentTask=None, log=None): | |||
| config = self.ConfigClass() | |||
| self._taskDict = dict() | |||
| loggerName = self._fullName | |||
| if log is not None: | |||
| if log is not None and log.getName(): | |||
There was a problem hiding this comment.
Good that this is fixed! This was causing a fairly obtuse error!
There was a problem hiding this comment.
getName() can return an empty string?
There was a problem hiding this comment.
Apparently yes. Try building pipe_base without this commit - testCmdLineTask fails with a fairly unhelpful error message.
There was a problem hiding this comment.
Yes, an empty string for the root logger.
Maybe we should improve the error message when we ask for a logger that doesn't make sense...
There was a problem hiding this comment.
Sure, I think that's a good idea.
Setting the log destination from a string will not be supported by the log package. So instead of printing an error message that implies --logdest will eventually be supported again, I simply removed it.
With this transition, arbitrary integers are no longer accepted as levels. Six formal levels are used: TRACE < DEBUG < INFO < WARN < ERROR < FATAL Default format and logging level are set to be similar to how it was. Logging calls at pex.logging DEBUG level is replaced by lsst.log DEBUG level.
Include showing timestamp and data IDs (stored as LABEL)
If a root logger (with an empty name) is passed to Task's ctor, there should not be an extra "." added to the Task's log name.
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
fa2c220
to
d509100
Compare
No description provided.