DM-7232: Py.test updates #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class AddTask(pipeBase.Task): | ||
| ConfigClass = AddConfig | ||
|
|
||
| @pipeBase.timeMethod | ||
| def run(self, val): | ||
| self.metadata.add("add", self.config.addend) | ||
| return pipeBase.Struct( | ||
| val = val + self.config.addend, | ||
| val=val + self.config.addend, |
There was a problem hiding this comment.
I'm sorry. I was wrong. I had not realised these were actually keyword arguments to a function. In which case the space around the equals is not allowed :-(
There was a problem hiding this comment.
They are corrected back to without the spaces.
AstroVPK
force-pushed
the
tickets/DM-7232
branch
from
a296ef9
to
73e134f
Compare
| if __name__ == '__main__': | ||
| run(True) | ||
| if __name__ == "__main__": | ||
| utilsTests.init() |
There was a problem hiding this comment.
we are trying to migrate away from using utilsTests short cut. It is preferred to use lsst.utils.tests explicitly.
There was a problem hiding this comment.
Woohoo! (camelCase namespace aliases are a pet peeve of mine).
hsinfang
force-pushed
the
tickets/DM-7232
branch
6 times, most recently
from
1b18b74
to
2392857
Compare
This commit updates tests/testTask.py to use the py.test framework.
Replaced assertTrue, assert_, & assertEquals.
This commit updates tests/testStruct.py to use the py.test framework.
Autopep8'd the test file.
This commit updates tests/testArgumentParser.py to use the py.test framework.
Autopep8'd the test file.
hsinfang
force-pushed
the
tickets/DM-7232
branch
from
2392857
to
f5aadfc
Compare
To avoid pytest warnings, rename TestTask to ExampleTask, TestMultipleIdTaskRunner to ExampleMultipleIdTaskRunner, and TestMultipleIdTask to ExampleMultipleIdTask.
The usage of aliases such as utilsTests is not encouraged anymore. This commit removes suych usage from testTask.py, testStruct.py and testArgumentParser.py
The namespace depends on the test runner environment.
hsinfang
force-pushed
the
tickets/DM-7232
branch
from
f5aadfc
to
9cd2862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.