Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-30266 Adopt a new QuantumGraph save format #202

Merged
merged 1 commit into from Dec 12, 2021
Merged

Conversation

natelust
Copy link
Contributor

This ticket modifies quantum graph to support using UUID to
identify QuantumNodes and serialize the graph out without using
pickle.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of small and a few medium comments here, but mostly all looks good.

python/lsst/pipe/base/graph/_loadHelpers.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/_loadHelpers.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/_loadHelpers.py Show resolved Hide resolved
python/lsst/pipe/base/graph/_loadHelpers.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/_versionDeserializers.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/graph.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/graph.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/graph.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graph/graph.py Show resolved Hide resolved
tests/test_quantumGraph.py Outdated Show resolved Hide resolved
@TallJimbo
Copy link
Member

Forgot to note earlier that at least this package does deserve a changelog entry, I think.

@natelust natelust force-pushed the tickets/DM-30266 branch 2 times, most recently from a773d13 to eaec6f6 Compare November 15, 2021 21:31
@natelust natelust force-pushed the tickets/DM-30266 branch 3 times, most recently from fbcc668 to adce40a Compare December 8, 2021 19:26
This ticket modifies quantum graph to support using UUID to
identify QuantumNodes and serialize the graph out without using
pickle.
@natelust natelust merged commit 2ad2f4e into main Dec 12, 2021
@natelust natelust deleted the tickets/DM-30266 branch December 12, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants