Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-32080 Correct the order of Parameter imports #207

Merged
merged 1 commit into from Oct 8, 2021
Merged

DM-32080 Correct the order of Parameter imports #207

merged 1 commit into from Oct 8, 2021

Conversation

natelust
Copy link
Contributor

@natelust natelust commented Oct 7, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

kfindeisen
kfindeisen approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please include DM-32080 in the PR title so that everything gets linked correctly.

@kfindeisen
Copy link
Member

Actually, I take it back: since this is a bug fix, I assume it goes in doc/changes?

@natelust natelust merged commit 0f96081 into master Oct 8, 2021
@natelust natelust deleted the tickets/DM-32080 branch October 8, 2021 15:55
@natelust natelust changed the title Correct the order of Parameter imports DM-32080 Correct the order of Parameter imports Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natelust @kfindeisen