DM-31801: Prepend Task loggers with "lsst" #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erykoff I'd appreciate your thoughts on this change to automatically prepend (effectivel) "lsst." to task loggers. I'm being careful not to force "lsst" as a prefix on every Task because I'm cognizant of people outside of LSST writing their own Tasks. They could of course set the class property to False to disable it but it seems reasonable to work it out ourselves. |
erykoff
reviewed
Oct 12, 2021
timj
force-pushed
the
tickets/DM-31801
branch
3 times, most recently
from
f4118be
to
78ec84f
Compare
ktlim
approved these changes
Nov 10, 2021
Rather than having to edit every single task to specify a module prefix, determing the module prefix automatically (usually "lsst") and prepend it if the logger name is being determined automatically. Provide a flag to disable this such that specific Task implementations can declare that the default name should be used on its own.
timj
force-pushed
the
tickets/DM-31801
branch
from
78ec84f
to
6a82db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows all Task loggers by default to be in the same logger hierarchy.
The code does not hard-code "lsst" but determines the prefix from the Task
__module__name.Checklist
doc/changes