Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33260 hotfix: make lsstimport optional #227

Merged
merged 1 commit into from Jan 19, 2022
Merged

Conversation

tgoldina
Copy link
Contributor

Hotfix for missed lsstimport in DM-33260.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@tgoldina tgoldina self-assigned this Jan 19, 2022
@tgoldina tgoldina requested a review from timj January 19, 2022 01:08
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess this worked before because the lsst/__init__.py can be picked up from daf_butler or utils but depending on import order you can hit the pipe_base one instead.

@tgoldina
Copy link
Contributor Author

Yes, I was installing pipe_base last.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #227 (ef7eb49) into main (2dc972b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   71.77%   71.77%           
=======================================
  Files          48       48           
  Lines        6148     6148           
  Branches     1188     1188           
=======================================
  Hits         4413     4413           
  Misses       1518     1518           
  Partials      217      217           
Impacted Files Coverage Δ
python/lsst/pipe/base/graph/graph.py 81.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc972b...ef7eb49. Read the comment docs.

@timj timj merged commit 8e9f149 into main Jan 19, 2022
@timj timj deleted the tickets/DM-33260-hotfix branch January 19, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants