Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33963: add TaskMetadata.get() and improve Pipeline YAML output #238

Merged
merged 3 commits into from Mar 25, 2022

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Mar 14, 2022

All these minor changes have in common is that they were useful for adding a particular new PipelineTask and pipelines for it in downstream packages.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #238 (58c9191) into main (1c50ebb) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   72.17%   72.27%   +0.09%     
==========================================
  Files          60       60              
  Lines        6595     6618      +23     
  Branches     1244     1246       +2     
==========================================
+ Hits         4760     4783      +23     
  Misses       1606     1606              
  Partials      229      229              
Impacted Files Coverage Δ
python/lsst/pipe/base/_task_metadata.py 98.17% <100.00%> (+0.04%) ⬆️
python/lsst/pipe/base/pipeline.py 63.90% <100.00%> (+0.27%) ⬆️
python/lsst/pipe/base/pipelineIR.py 85.89% <100.00%> (+0.17%) ⬆️
tests/test_pipelineIR.py 98.50% <100.00%> (+0.03%) ⬆️
tests/test_taskmetadata.py 97.64% <100.00%> (+0.07%) ⬆️
python/lsst/pipe/base/graph/graph.py 81.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c50ebb...58c9191. Read the comment docs.

@TallJimbo TallJimbo force-pushed the tickets/DM-33963 branch 3 times, most recently from 832976d to 4e9bf2a Compare March 14, 2022 16:21
tests/test_taskmetadata.py Outdated Show resolved Hide resolved
@TallJimbo TallJimbo force-pushed the tickets/DM-33963 branch 2 times, most recently from 9c8f9b5 to bd6c0b5 Compare March 14, 2022 16:41
@TallJimbo TallJimbo force-pushed the tickets/DM-33963 branch 2 times, most recently from bd6c0b5 to 297c02f Compare March 24, 2022 01:49
python/lsst/pipe/base/_task_metadata.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/pipeline.py Outdated Show resolved Hide resolved
This vastly improves the formatting of round-tripped config:python:
and documentation strings.
We don't want to force a TaskDef to be constructed in order to get at
this.
@TallJimbo TallJimbo merged commit 410bb9b into main Mar 25, 2022
@TallJimbo TallJimbo deleted the tickets/DM-33963 branch March 25, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants