Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33942: Use a negative integer for test universe #246

Closed
wants to merge 1 commit into from

Conversation

timj
Copy link
Member

@timj timj commented Apr 28, 2022

We currently cache universes based on version integer so we
need to use a version number that does not clash with any
possible real universe.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #246 (596145a) into main (590c34a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          60       60           
  Lines        6628     6628           
  Branches     1250     1250           
=======================================
  Hits         4782     4782           
  Misses       1621     1621           
  Partials      225      225           
Impacted Files Coverage Δ
tests/test_quantumGraph.py 94.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 590c34a...596145a. Read the comment docs.

This avoids the version number clashing with daf_butler dimensions.
@timj
Copy link
Member Author

timj commented May 5, 2022

Closed by #248

@timj timj closed this May 5, 2022
@timj timj deleted the tickets/DM-33942 branch May 5, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant