Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34616: Ensure implied dimensions are not null in test data IDs. #247

Closed
wants to merge 1 commit into from

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented May 2, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #247 (06c679f) into main (703ef5c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   72.14%   72.15%           
=======================================
  Files          60       60           
  Lines        6628     6629    +1     
  Branches     1250     1250           
=======================================
+ Hits         4782     4783    +1     
  Misses       1621     1621           
  Partials      225      225           
Impacted Files Coverage Δ
tests/test_testUtils.py 98.10% <100.00%> (+<0.01%) ⬆️
python/lsst/pipe/base/graph/graph.py 81.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703ef5c...06c679f. Read the comment docs.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I can't revoke approval, but I meant the above approval to be contingent on lsst/daf_butler#680 not having an alternative solution.

@TallJimbo
Copy link
Member Author

Changes to daf_butler on this ticket now make this branch unnecessary.

@TallJimbo TallJimbo closed this May 11, 2022
@TallJimbo TallJimbo deleted the tickets/DM-34616 branch May 11, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants