Add support for --show history=config.foo.bar #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
commented
Oct 10, 2016
| if mat: | ||
| pattern = mat.group(1) | ||
| matConfig = re.search(r"^config(?:=(?:config.)?(.+))?", what) | ||
| matHistory = None if matConfig else re.search(r"^history(?:=(?:config.)?(.+))?", what) |
There was a problem hiding this comment.
I find this too confusing. The search string "^history(?:=(?:config.)?(.+))?" seems far trickier than is required, and making matHistory use the results of matConfig seems needlessly complicated. It would be far clearer to keep the two independent of each other, even if it made the code a bit more verbose.
The number of options is large enough now that it may be worth a different approach, such as first testing all options that have no associated data, then using something like this for the remaining possibilities:
if what == "tasks":
....
elif what == "data":
....
... # test all items that cannot have associated data first, then...
else:
item, data = what.split("=", 1)
if item == "config":
configMatch = ...
elif item == "history":
historyMatch = ...
|
|
||
| sys.exit(1) | ||
|
|
||
| import lsst.pex.config.history as pch |
There was a problem hiding this comment.
Please import this at the top along with all other imports
The "config." is optional
RobertLuptonTheGood
force-pushed
the
tickets/DM-5421
branch
from
b101c85
to
c76d8f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "config." is optional