DM-34924: Check for dataset type compatibility when creating execution butler #251
Conversation
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 72.14% 71.95% -0.19%
==========================================
Files 60 60
Lines 6628 6651 +23
Branches 1250 1254 +4
==========================================
+ Hits 4782 4786 +4
- Misses 1621 1641 +20
+ Partials 225 224 -1
Continue to review full report at Codecov.
|
timj
force-pushed
the
tickets/DM-34924
branch
5 times, most recently
from
8ec15cf
to
f54b99b
Compare
| # Use the first type encountered. | ||
| return prevDsType | ||
|
|
||
| raise ValueError( |
There was a problem hiding this comment.
Suggest putting this in an explicit else clause for clarity
| dsType = registryDsType | ||
| else: | ||
| # Not compatible to re-raise the original exception. | ||
| raise |
There was a problem hiding this comment.
Please include a helpful error message as before, e.g., "Cannot insert {dsType} into the registry because it is incompatible with {registryDsType}"
There was a problem hiding this comment.
I am dreaming of python 3.11 exception notes. They would be perfect for this scenario. I think in this case though the exception that you are going to get is going to tell you "ConflictingDefinitionError(DatasetType A differs from Registry version B)" or something and there's not a lot I need to add.
A graph can contain dataset types that are shared with the dataset types that are automatically defined, but use different dataset types.
Checklist
doc/changes