DM-35082 Save DimensionUniverse in QuantumGraph #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 72.20% 72.29% +0.09%
==========================================
Files 60 60
Lines 6734 6768 +34
Branches 1387 1393 +6
==========================================
+ Hits 4862 4893 +31
- Misses 1649 1651 +2
- Partials 223 224 +1
Continue to review full report at Codecov.
|
Save the DimensionUniverse used to create the graph in the graphs header data. This removes the need to pass the Universe as an argument to load, and ensures that things are properly reconstructed, if the DimensionUniverse changes with a schema migration.
natelust
force-pushed
the
tickets/DM-35082
branch
4 times, most recently
from
9146a52
to
7f0195c
Compare
timj
reviewed
Jul 6, 2022
andy-slac
approved these changes
Jul 6, 2022
natelust
force-pushed
the
tickets/DM-35082
branch
3 times, most recently
from
48aaf2d
to
a1b8312
Compare
If a DimensionUniverse is supplied, check that it is compatible with the one saved in the graph.
natelust
force-pushed
the
tickets/DM-35082
branch
from
a1b8312
to
d915d8a
Compare
timj
reviewed
Jul 12, 2022
timj
reviewed
Jul 13, 2022
| if (universeConfig := infoMap.get("universe")) is not None: | ||
| universe = DimensionUniverse(config=DimensionConfig(universeConfig)) | ||
| else: | ||
| universe = DimensionUniverse() |
There was a problem hiding this comment.
I worry a bit that we should be using a universe that was passed into the loader if such a universe exists, although I imagine this code path is never going to trigger because historically people haven't been persisting their graph so that they can load it again 6 months later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the
DimensionUniverseused to create the graph in the graphs header data. This removes the need to pass the Universe as an argument to load, and ensures that things are properly reconstructed, if theDimensionUniversechanges with a schema migration.Requires lsst/daf_butler#711
Checklist
doc/changes