DM-33492: Enable store of resolved DatasetRefs in QuantumGraph #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-33492
branch
from
97f3967
to
6c65bf8
Compare
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 81.97% 81.97% -0.01%
==========================================
Files 59 59
Lines 6075 6074 -1
Branches 1237 1237
==========================================
- Hits 4980 4979 -1
Misses 869 869
Partials 226 226
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
andy-slac
force-pushed
the
tickets/DM-33492
branch
2 times, most recently
from
8a23226
to
d19595a
Compare
andy-slac
force-pushed
the
tickets/DM-33492
branch
2 times, most recently
from
5689190
to
0da1cfa
Compare
andy-slac
force-pushed
the
tickets/DM-33492
branch
2 times, most recently
from
118a0cb
to
6eac3ac
Compare
natelust
approved these changes
Aug 10, 2022
| @@ -845,6 +881,11 @@ def resolveDatasetRefs( | |||
| collectionTypes=CollectionType.RUN, | |||
| ) | |||
|
|
|||
| idMaker: Optional[_DatasetIdMaker] = None | |||
| if resolveRefs: | |||
| assert run is not None, "run cannot be None when resolveRefs is True" | |||
There was a problem hiding this comment.
Is assert really the right kind of exception to raise here?
There was a problem hiding this comment.
I think it's fine here, it is internal code only called from makeGraph(). makeGraph() has an explicit check that raises ValueError, here assert is mostly to keep mypy happy.
GraphBuilder adds an option to generate UUIDs for all unresolved references. For consistency we need to save resolved InitOutputs in the graph, so the graph is also extended to keep per-task refs for InitInputs and InitOutputs. InitInputs refs are also duplicated in each Quantum, we may consider dropping them later.
andy-slac
force-pushed
the
tickets/DM-33492
branch
2 times, most recently
from
e607be4
to
7c7412a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphBuilder adds an option to generate UUIDs for all unresolved
references. For consistency we need to save resolved InitOutputs
in the graph, so the graph is also extended to keep per-task refs for
InitInputs and InitOutputs. InitInputs refs are also duplicated in each
Quantum, we may consider dropping them later.
Checklist
doc/changes