Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36312: Handle components in registry queries manually. #284

Merged
merged 1 commit into from Oct 5, 2022

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Oct 4, 2022

daf_butler is deprecating support for components in Registry queries.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes (in daf_butler)

@TallJimbo TallJimbo requested a review from timj October 4, 2022 14:44
daf_butler is deprecating support for components in Registry queries.
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 81.99% // Head: 81.80% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (724e753) compared to base (00bbf2f).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   81.99%   81.80%   -0.19%     
==========================================
  Files          56       56              
  Lines        6126     6146      +20     
  Branches     1118     1126       +8     
==========================================
+ Hits         5023     5028       +5     
- Misses        873      886      +13     
- Partials      230      232       +2     
Impacted Files Coverage Δ
python/lsst/pipe/base/graphBuilder.py 67.76% <25.00%> (-1.97%) ⬇️
python/lsst/pipe/base/graph/graph.py 81.47% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TallJimbo TallJimbo merged commit dba8530 into main Oct 5, 2022
@TallJimbo TallJimbo deleted the tickets/DM-36312 branch October 5, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants