Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35082-v24: Save DimensionUniverse in QuantumGraph #290

Merged
merged 8 commits into from
Oct 24, 2022

Conversation

mwittgen
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

natelust and others added 7 commits October 13, 2022 13:09
Save the DimensionUniverse used to create the graph in the graphs
header data. This removes the need to pass the Universe as an
argument to load, and ensures that things are properly
reconstructed, if the DimensionUniverse changes with a schema
migration.
If a DimensionUniverse is supplied, check that it is compatible
with the one saved in the graph.
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 82.05% // Head: 72.26% // Decreases project coverage by -9.79% ⚠️

Coverage data is based on head (e4c80a2) compared to base (6b26e09).
Patch coverage: 85.93% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           v24.0.x     #290      +/-   ##
===========================================
- Coverage    82.05%   72.26%   -9.80%     
===========================================
  Files           56       60       +4     
  Lines         6092     6768     +676     
  Branches      1273     1208      -65     
===========================================
- Hits          4999     4891     -108     
- Misses         864     1652     +788     
+ Partials       229      225       -4     
Impacted Files Coverage Δ
python/lsst/pipe/base/graph/_loadHelpers.py 84.61% <ø> (-0.24%) ⬇️
python/lsst/pipe/base/tests/no_dimensions.py 0.00% <0.00%> (ø)
python/lsst/pipe/base/tests/simpleQGraph.py 69.48% <66.66%> (ø)
python/lsst/pipe/base/pipeline.py 61.61% <75.00%> (-0.06%) ⬇️
...thon/lsst/pipe/base/graph/_versionDeserializers.py 63.75% <84.61%> (-0.37%) ⬇️
python/lsst/pipe/base/config.py 69.49% <100.00%> (ø)
python/lsst/pipe/base/graph/graph.py 82.08% <100.00%> (+0.06%) ⬆️
python/lsst/pipe/base/testUtils.py 92.46% <100.00%> (ø)
tests/test_quantumGraph.py 95.13% <100.00%> (-0.29%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mwittgen mwittgen merged commit 06c5c31 into v24.0.x Oct 24, 2022
@mwittgen mwittgen deleted the tickets/DM-35082-v24 branch October 24, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants