Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-2850: Remove getSchemaCatalogs API #292

Merged
merged 4 commits into from Nov 18, 2022
Merged

DM-2850: Remove getSchemaCatalogs API #292

merged 4 commits into from Nov 18, 2022

Conversation

timj
Copy link
Member

@timj timj commented Nov 18, 2022

Not used in gen3.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This is a gen2 hold over for CmdLineTask usage.
This was only used in gen2.
@timj timj requested a review from TallJimbo November 18, 2022 19:54
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 81.32% // Head: 81.38% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (a4f207f) compared to base (a524345).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a4f207f differs from pull request most recent head ef6ab7c. Consider uploading reports for the commit ef6ab7c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   81.32%   81.38%   +0.05%     
==========================================
  Files          57       57              
  Lines        6202     6193       -9     
  Branches     1143     1142       -1     
==========================================
- Hits         5044     5040       -4     
+ Misses        926      920       -6     
- Partials      232      233       +1     
Impacted Files Coverage Δ
python/lsst/pipe/base/task.py 83.48% <ø> (+4.67%) ⬆️
python/lsst/pipe/base/tests/simpleQGraph.py 69.67% <ø> (ø)
python/lsst/pipe/base/connections.py 72.88% <100.00%> (ø)
python/lsst/pipe/base/pipelineIR.py 86.24% <100.00%> (ø)
python/lsst/pipe/base/graph/graph.py 81.57% <0.00%> (-0.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj
Copy link
Member Author

timj commented Nov 18, 2022

I'll fix that mypy problem -- it's triggered by the mypy 0.990 improvements and not related to this code change.

Some are from updated pyyaml typing and others are from mypy
0.990 being more careful with optional parameters.
@timj timj merged commit 37ba0fe into main Nov 18, 2022
@timj timj deleted the tickets/DM-2850 branch November 18, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants