Replace --trace with --logdest in ArgumentParser #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.add_argument("-L", "--loglevel", nargs="*", action=LogLevelAction, | ||
| help="logging level for component; supported levels are [debug|warn|info|fatal] or an integer; " | ||
| "use -n for trace level n", | ||
| metavar="LEVEL|COMPONENT=LEVEL") |
There was a problem hiding this comment.
It was not immediately obvious to me that the reference to -n meant --loglevel -n --- it looks like another argument name.
r-owen
force-pushed
the
tickets/DM-3698
branch
2 times, most recently
from
90390f9
to
7563516
Compare
Enhanced --logdest to support name=value arguments (like --trace) and eliminated --trace. Updated the unit test to test this modified functionality. The reason for this change is that use of pex_logging Trace and Debug is deprecated; all such logging should be done with Log. We are planning to switch from pex_logging to lsst.log and that will force this change, since lsst.log has no Trace or Debug. Thus we should have a way to set log level by log name. That is what --trace does, but --trace does not support named log levels and log level = - trace level, so using --trace for --loglevel is confusing. It is also confusing to have two different arguments that can and should do the same thing.
r-owen
force-pushed
the
tickets/DM-3698
branch
from
7563516
to
8023589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced --logdest to support name=value arguments (like --trace)
and eliminated --trace.
Updated the unit test to test this modified functionality.